lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 362/639] platform/x86: alienware-wmi: printing the wrong error code
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ]

    The "out_data" variable is uninitialized at the point. Originally, this
    used to print "status" instead and that seems like the correct thing to
    print.

    Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/platform/x86/alienware-wmi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c
    index c0d1555735cdd..83fd7677af24c 100644
    --- a/drivers/platform/x86/alienware-wmi.c
    +++ b/drivers/platform/x86/alienware-wmi.c
    @@ -587,7 +587,7 @@ static ssize_t show_hdmi_source(struct device *dev,
    return scnprintf(buf, PAGE_SIZE,
    "input [gpu] unknown\n");
    }
    - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data);
    + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status);
    return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n");
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:21    [W:2.292 / U:0.420 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site