lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 354/639] afs: Fix the afs.cell and afs.volume xattr handlers
    Date
    From: David Howells <dhowells@redhat.com>

    [ Upstream commit c73aa4102f5b9f261a907c3b3df94cd2c478504d ]

    Fix the ->get handlers for the afs.cell and afs.volume xattrs to pass the
    source data size to memcpy() rather than target buffer size.

    Overcopying the source data occasionally causes the kernel to oops.

    Fixes: d3e3b7eac886 ("afs: Add metadata xattrs")
    Signed-off-by: David Howells <dhowells@redhat.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/afs/xattr.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/fs/afs/xattr.c b/fs/afs/xattr.c
    index cfcc674e64a55..411f67c79f090 100644
    --- a/fs/afs/xattr.c
    +++ b/fs/afs/xattr.c
    @@ -50,7 +50,7 @@ static int afs_xattr_get_cell(const struct xattr_handler *handler,
    return namelen;
    if (namelen > size)
    return -ERANGE;
    - memcpy(buffer, cell->name, size);
    + memcpy(buffer, cell->name, namelen);
    return namelen;
    }

    @@ -104,7 +104,7 @@ static int afs_xattr_get_volume(const struct xattr_handler *handler,
    return namelen;
    if (namelen > size)
    return -ERANGE;
    - memcpy(buffer, volname, size);
    + memcpy(buffer, volname, namelen);
    return namelen;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:20    [W:4.063 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site