lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 335/639] netfilter: nft_flow_offload: add entry to flowtable after confirmation
    Date
    From: Pablo Neira Ayuso <pablo@netfilter.org>

    [ Upstream commit 270a8a297f42ecff82060aaa53118361f09c1f7d ]

    This is fixing flow offload for UDP traffic where packets only follow
    one single direction.

    The flow_offload_fixup_tcp() mechanism works fine in case that the
    offloaded entry remains in SYN_RECV state, given sequence tracking is
    reset and that conntrack handles syn+ack packets as a retransmission, ie.

    sES + synack => sIG

    for reply traffic.

    Fixes: a3c90f7a2323 ("netfilter: nf_tables: flow offload expression")
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/netfilter/nft_flow_offload.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/net/netfilter/nft_flow_offload.c b/net/netfilter/nft_flow_offload.c
    index 1ef8cb789c41a..166edea0e4527 100644
    --- a/net/netfilter/nft_flow_offload.c
    +++ b/net/netfilter/nft_flow_offload.c
    @@ -103,8 +103,7 @@ static void nft_flow_offload_eval(const struct nft_expr *expr,
    ct->status & IPS_SEQ_ADJUST)
    goto out;

    - if (ctinfo == IP_CT_NEW ||
    - ctinfo == IP_CT_RELATED)
    + if (!nf_ct_is_confirmed(ct))
    goto out;

    if (test_and_set_bit(IPS_OFFLOAD_BIT, &ct->status))
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:19    [W:3.023 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site