lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 296/639] drm/vmwgfx: Remove set but not used variable restart
    Date
    From: YueHaibing <yuehaibing@huawei.com>

    [ Upstream commit b2130cca9c8db5073b71d832da2a6c8311a8f3bb ]

    Fixes gcc '-Wunused-but-set-variable' warning:

    drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c: In function 'vmw_cmdbuf_work_func':
    drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:514:7: warning:
    variable 'restart' set but not used [-Wunused-but-set-variable]

    It not used any more after commit dc366364c4ef ("drm/vmwgfx: Fix multiple
    command buffer context use")

    Signed-off-by: YueHaibing <yuehaibing@huawei.com>
    Reviewed-by: Deepak Rawat <drawat@vmware.com>
    Signed-off-by: Deepak Rawat <drawat@vmware.com>
    Fixes: dc366364c4ef ("drm/vmwgfx: Fix multiple command buffer context use")
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
    index e7e4655d3f36b..ce1ad7cd78996 100644
    --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
    +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
    @@ -511,17 +511,14 @@ static void vmw_cmdbuf_work_func(struct work_struct *work)
    container_of(work, struct vmw_cmdbuf_man, work);
    struct vmw_cmdbuf_header *entry, *next;
    uint32_t dummy;
    - bool restart[SVGA_CB_CONTEXT_MAX];
    bool send_fence = false;
    struct list_head restart_head[SVGA_CB_CONTEXT_MAX];
    int i;
    struct vmw_cmdbuf_context *ctx;
    bool global_block = false;

    - for_each_cmdbuf_ctx(man, i, ctx) {
    + for_each_cmdbuf_ctx(man, i, ctx)
    INIT_LIST_HEAD(&restart_head[i]);
    - restart[i] = false;
    - }

    mutex_lock(&man->error_mutex);
    spin_lock(&man->lock);
    @@ -533,7 +530,6 @@ static void vmw_cmdbuf_work_func(struct work_struct *work)
    const char *cmd_name;

    list_del_init(&entry->list);
    - restart[entry->cb_context] = true;
    global_block = true;

    if (!vmw_cmd_describe(header, &error_cmd_size, &cmd_name)) {
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:17    [W:4.574 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site