lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 288/639] soc/fsl/qe: Fix an error code in qe_pin_request()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 5674a92ca4b7e5a6a19231edd10298d30324cd27 ]

    We forgot to set "err" on this error path.

    Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of of_get_named_gpio_flags()")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Li Yang <leoyang.li@nxp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/fsl/qe/gpio.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c
    index 819bed0f56679..51b3a47b5a559 100644
    --- a/drivers/soc/fsl/qe/gpio.c
    +++ b/drivers/soc/fsl/qe/gpio.c
    @@ -179,8 +179,10 @@ struct qe_pin *qe_pin_request(struct device_node *np, int index)
    if (err < 0)
    goto err0;
    gc = gpio_to_chip(err);
    - if (WARN_ON(!gc))
    + if (WARN_ON(!gc)) {
    + err = -ENODEV;
    goto err0;
    + }

    if (!of_device_is_compatible(gc->of_node, "fsl,mpc8323-qe-pario-bank")) {
    pr_debug("%s: tried to get a non-qe pin\n", __func__);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:15    [W:4.023 / U:0.592 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site