lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 265/639] media: cx18: update *pos correctly in cx18_read_pos()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 7afb0df554292dca7568446f619965fb8153085d ]

    We should be updating *pos. The current code is a no-op.

    Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip")

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/pci/cx18/cx18-fileops.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/pci/cx18/cx18-fileops.c b/drivers/media/pci/cx18/cx18-fileops.c
    index a3f44e30f8219..88c2f3bea2b61 100644
    --- a/drivers/media/pci/cx18/cx18-fileops.c
    +++ b/drivers/media/pci/cx18/cx18-fileops.c
    @@ -484,7 +484,7 @@ static ssize_t cx18_read_pos(struct cx18_stream *s, char __user *ubuf,

    CX18_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc);
    if (rc > 0)
    - pos += rc;
    + *pos += rc;
    return rc;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:15    [W:4.017 / U:1.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site