lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 197/639] usb: phy: twl6030-usb: fix possible use-after-free on remove
    Date
    From: Sven Van Asbroeck <thesven73@gmail.com>

    [ Upstream commit 5895d311d28f2605e2f71c1a3e043ed38f3ac9d2 ]

    In remove(), use cancel_delayed_work_sync() to cancel the
    delayed work. Otherwise there's a chance that this work
    will continue to run until after the device has been removed.

    This issue was detected with the help of Coccinelle.

    Cc: Tony Lindgren <tony@atomide.com>
    Cc: Bin Liu <b-liu@ti.com>
    Fixes: b6a619a883c3 ("usb: phy: Check initial state for twl6030")
    Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/phy/phy-twl6030-usb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
    index 183550b63faad..dade34d704198 100644
    --- a/drivers/usb/phy/phy-twl6030-usb.c
    +++ b/drivers/usb/phy/phy-twl6030-usb.c
    @@ -400,7 +400,7 @@ static int twl6030_usb_remove(struct platform_device *pdev)
    {
    struct twl6030_usb *twl = platform_get_drvdata(pdev);

    - cancel_delayed_work(&twl->get_status_work);
    + cancel_delayed_work_sync(&twl->get_status_work);
    twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,
    REG_INT_MSK_LINE_C);
    twl6030_interrupt_mask(TWL6030_USBOTG_INT_MASK,
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:11    [W:4.172 / U:1.460 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site