lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 185/639] ipmi: kcs_bmc: handle devm_kasprintf() failure case
    Date
    From: Nicholas Mc Guire <hofrat@osadl.org>

    [ Upstream commit 42c7c6ef1e6fa5fc0425120f06f045190b1dda2d ]

    devm_kasprintf() may return NULL if internal allocation failed so this
    assignment is not safe. Moved the error exit path and added the !NULL
    which then allows the devres manager to take care of cleanup.

    Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
    Fixes: cd2315d471f4 ("ipmi: kcs_bmc: don't change device name")
    Signed-off-by: Corey Minyard <cminyard@mvista.com>
    Reviewed-by: Haiyue Wang <haiyue.wang@linux.intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/char/ipmi/kcs_bmc.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c
    index e6124bd548df2..ed4dc3b1843e3 100644
    --- a/drivers/char/ipmi/kcs_bmc.c
    +++ b/drivers/char/ipmi/kcs_bmc.c
    @@ -440,12 +440,13 @@ struct kcs_bmc *kcs_bmc_alloc(struct device *dev, int sizeof_priv, u32 channel)
    kcs_bmc->data_in = devm_kmalloc(dev, KCS_MSG_BUFSIZ, GFP_KERNEL);
    kcs_bmc->data_out = devm_kmalloc(dev, KCS_MSG_BUFSIZ, GFP_KERNEL);
    kcs_bmc->kbuffer = devm_kmalloc(dev, KCS_MSG_BUFSIZ, GFP_KERNEL);
    - if (!kcs_bmc->data_in || !kcs_bmc->data_out || !kcs_bmc->kbuffer)
    - return NULL;

    kcs_bmc->miscdev.minor = MISC_DYNAMIC_MINOR;
    kcs_bmc->miscdev.name = devm_kasprintf(dev, GFP_KERNEL, "%s%u",
    DEVICE_NAME, channel);
    + if (!kcs_bmc->data_in || !kcs_bmc->data_out || !kcs_bmc->kbuffer ||
    + !kcs_bmc->miscdev.name)
    + return NULL;
    kcs_bmc->miscdev.fops = &kcs_bmc_fops;

    return kcs_bmc;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:09    [W:3.028 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site