lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 123/639] fork, memcg: fix cached_stacks case
    Date
    From: Shakeel Butt <shakeelb@google.com>

    [ Upstream commit ba4a45746c362b665e245c50b870615f02f34781 ]

    Commit 5eed6f1dff87 ("fork,memcg: fix crash in free_thread_stack on
    memcg charge fail") fixes a crash caused due to failed memcg charge of
    the kernel stack. However the fix misses the cached_stacks case which
    this patch fixes. So, the same crash can happen if the memcg charge of
    a cached stack is failed.

    Link: http://lkml.kernel.org/r/20190102180145.57406-1-shakeelb@google.com
    Fixes: 5eed6f1dff87 ("fork,memcg: fix crash in free_thread_stack on memcg charge fail")
    Signed-off-by: Shakeel Butt <shakeelb@google.com>
    Acked-by: Michal Hocko <mhocko@suse.com>
    Acked-by: Rik van Riel <riel@surriel.com>
    Cc: Rik van Riel <riel@surriel.com>
    Cc: Roman Gushchin <guro@fb.com>
    Cc: Johannes Weiner <hannes@cmpxchg.org>
    Cc: Tejun Heo <tj@kernel.org>
    Cc: <stable@vger.kernel.org>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    kernel/fork.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/kernel/fork.c b/kernel/fork.c
    index 5718c5decc55b..1bd119530a492 100644
    --- a/kernel/fork.c
    +++ b/kernel/fork.c
    @@ -216,6 +216,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node)
    memset(s->addr, 0, THREAD_SIZE);

    tsk->stack_vm_area = s;
    + tsk->stack = s->addr;
    return s->addr;
    }

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:07    [W:2.850 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site