lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 133/639] drm/etnaviv: NULL vs IS_ERR() buf in etnaviv_core_dump()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit f8261c376e7f8cb9024af5a6c54be540c7f9108e ]

    The etnaviv_gem_get_pages() never returns NULL. It returns error
    pointers on error.

    Fixes: a8c21a5451d8 ("drm/etnaviv: add initial etnaviv DRM driver")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/etnaviv/etnaviv_dump.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpu/drm/etnaviv/etnaviv_dump.c b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
    index 468dff2f79040..9d839b4fd8f78 100644
    --- a/drivers/gpu/drm/etnaviv/etnaviv_dump.c
    +++ b/drivers/gpu/drm/etnaviv/etnaviv_dump.c
    @@ -217,7 +217,7 @@ void etnaviv_core_dump(struct etnaviv_gpu *gpu)
    mutex_lock(&obj->lock);
    pages = etnaviv_gem_get_pages(obj);
    mutex_unlock(&obj->lock);
    - if (pages) {
    + if (!IS_ERR(pages)) {
    int j;

    iter.hdr->data[0] = bomap - bomap_start;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:06    [W:4.150 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site