lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 113/639] clk: mv98dx3236: fix refcount leak in mv98dx3236_clk_init()
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit 9b4eedf627045ae5ddcff60a484200cdd554c413 ]

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/mvebu/mv98dx3236.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/clk/mvebu/mv98dx3236.c b/drivers/clk/mvebu/mv98dx3236.c
    index 6e203af73cac1..c8a0d03d2cd60 100644
    --- a/drivers/clk/mvebu/mv98dx3236.c
    +++ b/drivers/clk/mvebu/mv98dx3236.c
    @@ -174,7 +174,9 @@ static void __init mv98dx3236_clk_init(struct device_node *np)

    mvebu_coreclk_setup(np, &mv98dx3236_core_clocks);

    - if (cgnp)
    + if (cgnp) {
    mvebu_clk_gating_setup(cgnp, mv98dx3236_gating_desc);
    + of_node_put(cgnp);
    + }
    }
    CLK_OF_DECLARE(mv98dx3236_clk, "marvell,mv98dx3236-core-clock", mv98dx3236_clk_init);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:05    [W:4.018 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site