lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 111/639] clk: kirkwood: fix refcount leak in kirkwood_clk_init()
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit e7beeab9c61591cd0e690d8733d534c3f4278ff8 ]

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
    Fixes: 58d516ae95cb ("clk: mvebu: kirkwood: maintain clock init order")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/mvebu/kirkwood.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/clk/mvebu/kirkwood.c b/drivers/clk/mvebu/kirkwood.c
    index a2a8d614039da..890ebf623261b 100644
    --- a/drivers/clk/mvebu/kirkwood.c
    +++ b/drivers/clk/mvebu/kirkwood.c
    @@ -333,6 +333,8 @@ static void __init kirkwood_clk_init(struct device_node *np)
    if (cgnp) {
    mvebu_clk_gating_setup(cgnp, kirkwood_gating_desc);
    kirkwood_clk_muxing_setup(cgnp, kirkwood_mux_desc);
    +
    + of_node_put(cgnp);
    }
    }
    CLK_OF_DECLARE(kirkwood_clk, "marvell,kirkwood-core-clock",
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:05    [W:4.028 / U:0.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site