lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 103/639] clk: ti: fix refcount leak in ti_dt_clocks_register()
    Date
    From: Yangtao Li <tiny.windzz@gmail.com>

    [ Upstream commit 2274d8001fbb5e1942fbcab5ad2eb15553b09ed2 ]

    The of_find_compatible_node() returns a node pointer with refcount
    incremented, but there is the lack of use of the of_node_put() when
    done. Add the missing of_node_put() to release the refcount.

    Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
    Fixes: 5b385a45e001 ("clk: ti: add support for clkctrl aliases")
    Signed-off-by: Stephen Boyd <sboyd@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/clk/ti/clk.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/clk/ti/clk.c b/drivers/clk/ti/clk.c
    index 27e0979b31586..0cc87c6ae91c9 100644
    --- a/drivers/clk/ti/clk.c
    +++ b/drivers/clk/ti/clk.c
    @@ -188,9 +188,13 @@ void __init ti_dt_clocks_register(struct ti_dt_clk oclks[])
    clkdev_add(&c->lk);
    } else {
    if (num_args && !has_clkctrl_data) {
    - if (of_find_compatible_node(NULL, NULL,
    - "ti,clkctrl")) {
    + struct device_node *np;
    +
    + np = of_find_compatible_node(NULL, NULL,
    + "ti,clkctrl");
    + if (np) {
    has_clkctrl_data = true;
    + of_node_put(np);
    } else {
    clkctrl_nodes_missing = true;

    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:04    [W:2.115 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site