lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 050/639] pwm: lpss: Release runtime-pm reference from the drivers remove callback
    Date
    From: Hans de Goede <hdegoede@redhat.com>

    [ Upstream commit 42885551cedb45961879d2fc3dc3c4dc545cc23e ]

    For each pwm output which gets enabled through pwm_lpss_apply(), we do a
    pm_runtime_get_sync().

    This commit adds pm_runtime_put() calls to pwm_lpss_remove() to balance
    these when the driver gets removed with some of the outputs still enabled.

    Fixes: f080be27d7d9 ("pwm: lpss: Add support for runtime PM")
    Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pwm/pwm-lpss.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c
    index 1e69c1c9ec096..7a4a6406cf69a 100644
    --- a/drivers/pwm/pwm-lpss.c
    +++ b/drivers/pwm/pwm-lpss.c
    @@ -216,6 +216,12 @@ EXPORT_SYMBOL_GPL(pwm_lpss_probe);

    int pwm_lpss_remove(struct pwm_lpss_chip *lpwm)
    {
    + int i;
    +
    + for (i = 0; i < lpwm->info->npwm; i++) {
    + if (pwm_is_enabled(&lpwm->chip.pwms[i]))
    + pm_runtime_put(lpwm->chip.dev);
    + }
    return pwmchip_remove(&lpwm->chip);
    }
    EXPORT_SYMBOL_GPL(pwm_lpss_remove);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:01    [W:4.664 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site