lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 188/343] net: ena: fix swapped parameters when calling ena_com_indirect_table_fill_entry
    Date
    From: Sameeh Jubran <sameehj@amazon.com>

    [ Upstream commit 3c6eeff295f01bdf1c6c3addcb0a04c0c6c029e9 ]

    second parameter should be the index of the table rather than the value.

    Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")
    Signed-off-by: Saeed Bshara <saeedb@amazon.com>
    Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/amazon/ena/ena_ethtool.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/amazon/ena/ena_ethtool.c b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
    index 967020fb26ee1..a2f02c23fe141 100644
    --- a/drivers/net/ethernet/amazon/ena/ena_ethtool.c
    +++ b/drivers/net/ethernet/amazon/ena/ena_ethtool.c
    @@ -694,8 +694,8 @@ static int ena_set_rxfh(struct net_device *netdev, const u32 *indir,
    if (indir) {
    for (i = 0; i < ENA_RX_RSS_TABLE_SIZE; i++) {
    rc = ena_com_indirect_table_fill_entry(ena_dev,
    - ENA_IO_RXQ_IDX(indir[i]),
    - i);
    + i,
    + ENA_IO_RXQ_IDX(indir[i]));
    if (unlikely(rc)) {
    netif_err(adapter, drv, netdev,
    "Cannot fill indirect table (index is too large)\n");
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 10:58    [W:4.116 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site