lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 057/343] IB/usnic: Fix out of bounds index check in query pkey
    Date
    From: Gal Pressman <galpress@amazon.com>

    [ Upstream commit 4959d5da5737dd804255c75b8cea0a2929ce279a ]

    The pkey table size is one element, index should be tested for > 0 instead
    of > 1.

    Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
    Signed-off-by: Gal Pressman <galpress@amazon.com>
    Acked-by: Parvi Kaustubhi <pkaustub@cisco.com>
    Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
    index fdfa25059723d..2602c7375d585 100644
    --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
    +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
    @@ -423,7 +423,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num)
    int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index,
    u16 *pkey)
    {
    - if (index > 1)
    + if (index > 0)
    return -EINVAL;

    *pkey = 0xffff;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 10:47    [W:4.048 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site