Messages in this thread | | | From | Brendan Higgins <> | Date | Fri, 24 Jan 2020 14:03:55 -0800 | Subject | Re: [PATCH v2] uml: make CONFIG_STATIC_LINK actually static |
| |
On Thu, Jan 23, 2020 at 11:51 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Brendan, > > On Fri, Jan 24, 2020 at 12:59 AM Brendan Higgins > <brendanhiggins@google.com> wrote: > > Currently, CONFIG_STATIC_LINK can be enabled with options which cannot > > be statically linked, namely UML_NET_VECTOR, UML_NET_VDE, and > > UML_NET_PCAP; this is because glibc tries to load NSS which does not > > support being statically linked. So make CONFIG_STATIC_LINK depend on > > !UML_NET_VECTOR && !UML_NET_VDE && !UML_NET_PCAP. > > > > Link: https://lore.kernel.org/lkml/f658f317-be54-ed75-8296-c373c2dcc697@cambridgegreys.com/#t > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > --- > > Changes since last revision: > > > > Incorporated Geert Uytterhoeven's suggestion of using a separate > > FORBID_STATIC_LINK config option that each driver incompatible with > > static linking selects. > > --- > > arch/um/Kconfig | 7 +++++++ > > arch/um/drivers/Kconfig | 3 +++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/arch/um/Kconfig b/arch/um/Kconfig > > index 0917f8443c285..27a51e7dd59c6 100644 > > --- a/arch/um/Kconfig > > +++ b/arch/um/Kconfig > > @@ -62,8 +62,12 @@ config NR_CPUS > > > > source "arch/$(HEADER_ARCH)/um/Kconfig" > > > > +config FORBID_STATIC_LINK > > + def_bool n > > bool > > ("n" is the default)
Whoops, I always forget that.
Thanks for catching that!
> > + > > config STATIC_LINK > > bool "Force a static link" > > + depends on !FORBID_STATIC_LINK > > default n > > "default n" is the default (preexisting)
I'll go ahead and fix that too, then.
Thanks!
| |