lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 002/639] xfs: Sanity check flags of Q_XQUOTARM call
    Date
    From: Jan Kara <jack@suse.cz>

    commit 3dd4d40b420846dd35869ccc8f8627feef2cff32 upstream.

    Flags passed to Q_XQUOTARM were not sanity checked for invalid values.
    Fix that.

    Fixes: 9da93f9b7cdf ("xfs: fix Q_XQUOTARM ioctl")
    Reported-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Reviewed-by: Eric Sandeen <sandeen@redhat.com>
    Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/xfs/xfs_quotaops.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/fs/xfs/xfs_quotaops.c
    +++ b/fs/xfs/xfs_quotaops.c
    @@ -202,6 +202,9 @@ xfs_fs_rm_xquota(
    if (XFS_IS_QUOTA_ON(mp))
    return -EINVAL;

    + if (uflags & ~(FS_USER_QUOTA | FS_GROUP_QUOTA | FS_PROJ_QUOTA))
    + return -EINVAL;
    +
    if (uflags & FS_USER_QUOTA)
    flags |= XFS_DQ_USER;
    if (uflags & FS_GROUP_QUOTA)

    \
     
     \ /
      Last update: 2020-01-24 10:38    [W:4.323 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site