lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 007/343] leds: tlc591xx: update the maximum brightness
    Date
    From: Jean-Jacques Hiblot <jjhiblot@ti.com>

    commit a2cafdfd8cf5ad8adda6c0ce44a59f46431edf02 upstream.

    The TLC chips actually offer 257 levels:
    - 0: led OFF
    - 1-255: Led dimmed is using a PWM. The duty cycle range from 0.4% to 99.6%
    - 256: led fully ON

    Fixes: e370d010a5fe ("leds: tlc591xx: Driver for the TI 8/16 Channel i2c LED driver")
    Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
    Signed-off-by: Pavel Machek <pavel@ucw.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/leds/leds-tlc591xx.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    --- a/drivers/leds/leds-tlc591xx.c
    +++ b/drivers/leds/leds-tlc591xx.c
    @@ -16,6 +16,7 @@
    #include <linux/slab.h>

    #define TLC591XX_MAX_LEDS 16
    +#define TLC591XX_MAX_BRIGHTNESS 256

    #define TLC591XX_REG_MODE1 0x00
    #define MODE1_RESPON_ADDR_MASK 0xF0
    @@ -115,11 +116,11 @@ tlc591xx_brightness_set(struct led_class
    struct tlc591xx_priv *priv = led->priv;
    int err;

    - switch (brightness) {
    + switch ((int)brightness) {
    case 0:
    err = tlc591xx_set_ledout(priv, led, LEDOUT_OFF);
    break;
    - case LED_FULL:
    + case TLC591XX_MAX_BRIGHTNESS:
    err = tlc591xx_set_ledout(priv, led, LEDOUT_ON);
    break;
    default:
    @@ -160,7 +161,7 @@ tlc591xx_configure(struct device *dev,
    led->priv = priv;
    led->led_no = i;
    led->ldev.brightness_set_blocking = tlc591xx_brightness_set;
    - led->ldev.max_brightness = LED_FULL;
    + led->ldev.max_brightness = TLC591XX_MAX_BRIGHTNESS;
    err = led_classdev_register(dev, &led->ldev);
    if (err < 0) {
    dev_err(dev, "couldn't register LED %s\n",

    \
     
     \ /
      Last update: 2020-01-24 10:37    [W:4.089 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site