lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 015/102] i2c: i2c-stm32f7: fix 10-bits check in slave free id search loop
    Date
    From: Alain Volmat <alain.volmat@st.com>

    commit 7787657d7ee55a9ecf4aea4907b46b87a44eda67 upstream.

    Fix a typo in the free slave id search loop. Instead of I2C_CLIENT_PEC,
    it should have been I2C_CLIENT_TEN. The slave id 1 can only handle 7-bit
    addresses and thus is not eligible in case of 10-bit addresses.
    As a matter of fact none of the slave id support I2C_CLIENT_PEC, overall
    check is performed at the beginning of the stm32f7_i2c_reg_slave function.

    Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
    Signed-off-by: Alain Volmat <alain.volmat@st.com>
    Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/i2c/busses/i2c-stm32f7.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/i2c/busses/i2c-stm32f7.c
    +++ b/drivers/i2c/busses/i2c-stm32f7.c
    @@ -1268,7 +1268,7 @@ static int stm32f7_i2c_get_free_slave_id
    * slave[1] supports 7-bit slave address only
    */
    for (i = STM32F7_I2C_MAX_SLAVE - 1; i >= 0; i--) {
    - if (i == 1 && (slave->flags & I2C_CLIENT_PEC))
    + if (i == 1 && (slave->flags & I2C_CLIENT_TEN))
    continue;
    if (!i2c_dev->slave[i]) {
    *id = i;

    \
     
     \ /
      Last update: 2020-01-24 10:35    [W:4.616 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site