lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 083/107] net/wan/fsl_ucc_hdlc: fix out of bounds write on array utdm_info
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit ddf420390526ede3b9ff559ac89f58cb59d9db2f ]

    Array utdm_info is declared as an array of MAX_HDLC_NUM (4) elements
    however up to UCC_MAX_NUM (8) elements are potentially being written
    to it. Currently we have an array out-of-bounds write error on the
    last 4 elements. Fix this by making utdm_info UCC_MAX_NUM elements in
    size.

    Addresses-Coverity: ("Out-of-bounds write")
    Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/wan/fsl_ucc_hdlc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
    index ca0f3be2b6bf8..aef7de225783f 100644
    --- a/drivers/net/wan/fsl_ucc_hdlc.c
    +++ b/drivers/net/wan/fsl_ucc_hdlc.c
    @@ -73,7 +73,7 @@ static struct ucc_tdm_info utdm_primary_info = {
    },
    };

    -static struct ucc_tdm_info utdm_info[MAX_HDLC_NUM];
    +static struct ucc_tdm_info utdm_info[UCC_MAX_NUM];

    static int uhdlc_init(struct ucc_hdlc_private *priv)
    {
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-24 15:34    [W:4.821 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site