lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 012/102] ARM: OMAP2+: Add missing put_device() call in omapdss_init_of()
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>

    commit 0b491904f053e41685162af5c5411b85b18c97a7 upstream.

    A coccicheck run provided information like the following.

    arch/arm/mach-omap2/display.c:268:2-8: ERROR: missing put_device;
    call of_find_device_by_node on line 258, but without a corresponding
    object release within this function.

    Generated by: scripts/coccinelle/free/put_device.cocci

    Thus add the missed function call to fix the exception handling for
    this function implementation.

    Fixes: e0c827aca0730b51f38081aa4e8ecf0912aab55f ("drm/omap: Populate DSS children in omapdss driver")
    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    Signed-off-by: Tony Lindgren <tony@atomide.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/mach-omap2/display.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/arch/arm/mach-omap2/display.c
    +++ b/arch/arm/mach-omap2/display.c
    @@ -265,6 +265,7 @@ static int __init omapdss_init_of(void)
    r = of_platform_populate(node, NULL, NULL, &pdev->dev);
    if (r) {
    pr_err("Unable to populate DSS submodule devices\n");
    + put_device(&pdev->dev);
    return r;
    }


    \
     
     \ /
      Last update: 2020-01-24 10:34    [W:4.113 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site