lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 12/32] ASoC: msm8916-wcd-analog: Fix selected events for MIC BIAS External1
    Date
    From: Stephan Gerhold <stephan@gerhold.net>

    [ Upstream commit e0beec88397b163c7c4ea6fcfb67e8e07a2671dc ]

    MIC BIAS External1 sets pm8916_wcd_analog_enable_micbias_ext1()
    as event handler, which ends up in pm8916_wcd_analog_enable_micbias_ext().

    But pm8916_wcd_analog_enable_micbias_ext() only handles the POST_PMU
    event, which is not specified in the event flags for MIC BIAS External1.
    This means that the code in the event handler is never actually run.

    Set SND_SOC_DAPM_POST_PMU as the only event for the handler to fix this.

    Fixes: 585e881e5b9e ("ASoC: codecs: Add msm8916-wcd analog codec")
    Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
    Link: https://lore.kernel.org/r/20200111164006.43074-2-stephan@gerhold.net
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/msm8916-wcd-analog.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/codecs/msm8916-wcd-analog.c b/sound/soc/codecs/msm8916-wcd-analog.c
    index 969283737787f..3633eb30dd135 100644
    --- a/sound/soc/codecs/msm8916-wcd-analog.c
    +++ b/sound/soc/codecs/msm8916-wcd-analog.c
    @@ -876,10 +876,10 @@ static const struct snd_soc_dapm_widget pm8916_wcd_analog_dapm_widgets[] = {

    SND_SOC_DAPM_SUPPLY("MIC BIAS External1", CDC_A_MICB_1_EN, 7, 0,
    pm8916_wcd_analog_enable_micbias_ext1,
    - SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
    + SND_SOC_DAPM_POST_PMU),
    SND_SOC_DAPM_SUPPLY("MIC BIAS External2", CDC_A_MICB_2_EN, 7, 0,
    pm8916_wcd_analog_enable_micbias_ext2,
    - SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
    + SND_SOC_DAPM_POST_PMU),

    SND_SOC_DAPM_ADC_E("ADC1", NULL, CDC_A_TX_1_EN, 7, 0,
    pm8916_wcd_analog_enable_adc,
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-24 15:22    [W:4.230 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site