Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [PATCH v3] perf/core: fix mlock accounting in perf_mmap() | Date | Fri, 24 Jan 2020 11:25:55 +0200 |
| |
Song Liu <songliubraving@fb.com> writes:
> Eecreasing sysctl_perf_event_mlock between two consecutive perf_mmap()s of
Typo: "Decreasing".
> a perf ring buffer may lead to an integer underflow in locked memory > accounting. This may lead to the undesired behaviors, such as failures in > BPF map creation. > > Address this by adjusting the accounting logic to take into account the > possibility that the amount of already locked memory may exceed the > current limit. > > Fixes: c4b75479741c ("perf/core: Make the mlock accounting simple again") > Signed-off-by: Song Liu <songliubraving@fb.com> > Suggested-by: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com> > Cc: Jiri Olsa <jolsa@kernel.org> > Cc: Peter Zijlstra <peterz@infradead.org>
Other than that,
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Thanks, -- Alex
| |