lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 049/639] netfilter: nft_osf: usage from output path is not valid
    Date
    From: Fernando Fernandez Mancera <ffmancera@riseup.net>

    [ Upstream commit 4a3e71b7b7dbaf3562be9d508260935aa13cb48b ]

    The nft_osf extension, like xt_osf, is not supported from the output
    path.

    Fixes: b96af92d6eaf ("netfilter: nf_tables: implement Passive OS fingerprint module in nft_osf")
    Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    net/netfilter/nft_osf.c | 10 ++++++++++
    1 file changed, 10 insertions(+)

    diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c
    index a35fb59ace732..df4e3e0412ed3 100644
    --- a/net/netfilter/nft_osf.c
    +++ b/net/netfilter/nft_osf.c
    @@ -69,6 +69,15 @@ nla_put_failure:
    return -1;
    }

    +static int nft_osf_validate(const struct nft_ctx *ctx,
    + const struct nft_expr *expr,
    + const struct nft_data **data)
    +{
    + return nft_chain_validate_hooks(ctx->chain, (1 << NF_INET_LOCAL_IN) |
    + (1 << NF_INET_PRE_ROUTING) |
    + (1 << NF_INET_FORWARD));
    +}
    +
    static struct nft_expr_type nft_osf_type;
    static const struct nft_expr_ops nft_osf_op = {
    .eval = nft_osf_eval,
    @@ -76,6 +85,7 @@ static const struct nft_expr_ops nft_osf_op = {
    .init = nft_osf_init,
    .dump = nft_osf_dump,
    .type = &nft_osf_type,
    + .validate = nft_osf_validate,
    };

    static struct nft_expr_type nft_osf_type __read_mostly = {
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:44    [W:2.514 / U:0.364 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site