lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 404/639] netvsc: unshare skb in VF rx handler
    Date
    From: Stephen Hemminger <stephen@networkplumber.org>

    [ Upstream commit 996ed04741467f6d1552440c92988b132a9487ec ]

    The netvsc VF skb handler should make sure that skb is not
    shared. Similar logic already exists in bonding and team device
    drivers.

    This is not an issue in practice because the VF devicex
    does not send up shared skb's. But the netvsc driver
    should do the right thing if it did.

    Fixes: 0c195567a8f6 ("netvsc: transparent VF management")
    Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/hyperv/netvsc_drv.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
    index 1f9f7fcdb0eb3..54670c9905c79 100644
    --- a/drivers/net/hyperv/netvsc_drv.c
    +++ b/drivers/net/hyperv/netvsc_drv.c
    @@ -2004,6 +2004,12 @@ static rx_handler_result_t netvsc_vf_handle_frame(struct sk_buff **pskb)
    struct netvsc_vf_pcpu_stats *pcpu_stats
    = this_cpu_ptr(ndev_ctx->vf_stats);

    + skb = skb_share_check(skb, GFP_ATOMIC);
    + if (unlikely(!skb))
    + return RX_HANDLER_CONSUMED;
    +
    + *pskb = skb;
    +
    skb->dev = ndev;

    u64_stats_update_begin(&pcpu_stats->syncp);
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:41    [W:2.342 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site