lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 470/639] PCI: mobiveil: Fix devfn check in mobiveil_pcie_valid_device()
    Date
    From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

    [ Upstream commit cbd50b3ca3964c79dac65fda277637577e029e8c ]

    Current check for devfn number in mobiveil_pci_valid_device() is
    wrong in that it flags as invalid functions present in PCI device 0
    in the root bus while it is perfectly valid to access all functions
    in PCI device 0 in the root bus.

    Update the check in mobiveil_pci_valid_device() to fix the issue.

    Fixes: 9af6bcb11e12 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
    Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pcie-mobiveil.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/pcie-mobiveil.c b/drivers/pci/controller/pcie-mobiveil.c
    index dc228eb500edd..476be4f3c7f6e 100644
    --- a/drivers/pci/controller/pcie-mobiveil.c
    +++ b/drivers/pci/controller/pcie-mobiveil.c
    @@ -174,7 +174,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
    * Do not read more than one device on the bus directly
    * attached to RC
    */
    - if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
    + if ((bus->primary == pcie->root_bus_nr) && (PCI_SLOT(devfn) > 0))
    return false;

    return true;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:40    [W:3.761 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site