lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 174/343] media: ov2659: fix unbalanced mutex_lock/unlock
    Date
    From: Akinobu Mita <akinobu.mita@gmail.com>

    [ Upstream commit 384538bda10913e5c94ec5b5d34bd3075931bcf4 ]

    Avoid returning with mutex locked.

    Fixes: fa8cb6444c32 ("[media] ov2659: Don't depend on subdev API")

    Cc: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
    Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/media/i2c/ov2659.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c
    index 44b0584eb8a6c..e7768ed1ff9c2 100644
    --- a/drivers/media/i2c/ov2659.c
    +++ b/drivers/media/i2c/ov2659.c
    @@ -1136,7 +1136,7 @@ static int ov2659_set_fmt(struct v4l2_subdev *sd,
    mf = v4l2_subdev_get_try_format(sd, cfg, fmt->pad);
    *mf = fmt->format;
    #else
    - return -ENOTTY;
    + ret = -ENOTTY;
    #endif
    } else {
    s64 val;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:39    [W:4.031 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site