lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 583/639] net: nixge: Fix a signedness bug in nixge_probe()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 1a4b62a0b8a3b81eca24366f63e214a7144b9f02 ]

    The "priv->phy_mode" is an enum and in this context GCC will treat it
    as an unsigned int so it can never be less than zero.

    Fixes: 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/ni/nixge.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/ni/nixge.c b/drivers/net/ethernet/ni/nixge.c
    index 76efed058f334..a791d7932b0ef 100644
    --- a/drivers/net/ethernet/ni/nixge.c
    +++ b/drivers/net/ethernet/ni/nixge.c
    @@ -1233,7 +1233,7 @@ static int nixge_probe(struct platform_device *pdev)
    }

    priv->phy_mode = of_get_phy_mode(pdev->dev.of_node);
    - if (priv->phy_mode < 0) {
    + if ((int)priv->phy_mode < 0) {
    netdev_err(ndev, "not find \"phy-mode\" property\n");
    err = -EINVAL;
    goto unregister_mdio;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:34    [W:4.016 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site