lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 528/639] hwmon: (lm75) Fix write operations for negative temperatures
    Date
    From: Guenter Roeck <linux@roeck-us.net>

    [ Upstream commit 7d82fcc9d9e81241778aaa22fda7be753e237d86 ]

    Writes into limit registers fail if the temperature written is negative.
    The regmap write operation checks the value range, regmap_write accepts
    an unsigned int as parameter, and the temperature value passed to
    regmap_write is kept in a variable declared as long. Negative values
    are converted large unsigned integers, which fails the range check.
    Fix by type casting the temperature to u16 when calling regmap_write().

    Cc: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
    Fixes: e65365fed87f ("hwmon: (lm75) Convert to use regmap")
    Signed-off-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/hwmon/lm75.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
    index 49f4b33a5685a..7f28912c9abcf 100644
    --- a/drivers/hwmon/lm75.c
    +++ b/drivers/hwmon/lm75.c
    @@ -165,7 +165,7 @@ static int lm75_write(struct device *dev, enum hwmon_sensor_types type,
    temp = DIV_ROUND_CLOSEST(temp << (resolution - 8),
    1000) << (16 - resolution);

    - return regmap_write(data->regmap, reg, temp);
    + return regmap_write(data->regmap, reg, (u16)temp);
    }

    static umode_t lm75_is_visible(const void *data, enum hwmon_sensor_types type,
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:30    [W:2.428 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site