Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 3/3] alarmtimer: Always export alarmtimer_get_rtcdev() and update docs | Date | Fri, 24 Jan 2020 02:04:49 +0100 |
| |
Stephen Boyd <swboyd@chromium.org> writes: > The export isn't there for the stubbed version of > alarmtimer_get_rtcdev(), so move the export outside of the ifdef. And > rtcdev isn't used outside of this ifdef so we don't need to redefine it > as NULL.
This does not make any sense. Why would we export a trivial stub which just returns NULL?
The right thing to do is to make that an inline function in the relevant header file.
> @@ -67,8 +67,6 @@ static DEFINE_SPINLOCK(rtcdev_lock); > * alarmtimer_get_rtcdev - Return selected rtcdevice > * > * This function returns the rtc device to use for wakealarms. > - * If one has not already been chosen, it checks to see if a > - * functional rtc device is available.
Unrelated comment change which is not explained in the changelog. Please make that a separate patch as it has absolutely nothing to do with the stub function issue.
Thanks,
tglx
| |