Messages in this thread | | | Date | Thu, 23 Jan 2020 10:41:29 -0800 | From | Bjorn Andersson <> | Subject | Re: [v2] arm64: dts: sc7180: add display dt nodes |
| |
On Thu 23 Jan 04:15 PST 2020, Harigovindan P wrote:
> Add display, DSI hardware DT nodes for sc7180. > > Changes in v1: > -Added display DT nodes for sc7180 > Changes in v2: > -Renamed node names > -Corrected code alignments > -Removed extra new line
Please keep the changelist after the '---' for the dts patches.
> > Signed-off-by: Harigovindan P <harigovi@codeaurora.org> > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 57 +++++++++++++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 125 ++++++++++++++++++++++++++++++++ > 2 files changed, 182 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50a..f410614 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -232,6 +232,50 @@ > }; > }; > > +&dsi_controller { > + status = "okay"; > + > + vdda-supply = <&vreg_l3c_1p2>; > + > + panel@0 { > + compatible = "visionox,rm69299-1080p-display"; > + reg = <0>; > + > + vdda-supply = <&vreg_l8c_1p8>; > + vdd3p3-supply = <&vreg_l18a_2p8>; > + > + pinctrl-names = "default", "suspend"; > + pinctrl-0 = <&disp_pins_default>; > + pinctrl-1 = <&disp_pins_default>; > + > + reset-gpios = <&pm6150l_gpio 3 0>;
Please replace the 0 here with GPIO_ACTIVE_HIGH
> + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + panel0_in: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + }; > + }; [..] > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 3bc3f64..81c3aab 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -1184,6 +1184,131 @@ > #power-domain-cells = <1>; > }; > > + display_subsystem: mdss@ae00000 {
It was the name, not the label, that Stephen asked you to make generic.
> + compatible = "qcom,sc7180-mdss"; > + reg = <0 0x0ae00000 0 0x1000>; > + reg-names = "mdss"; > + [..] > + display_controller: mdp@ae00000 {
mdp: display-controller@ae00000 {
[..] > + }; > + > + dsi_controller: qcom,mdss_dsi_ctrl0@ae94000 {
In particular you shouldn't have qcom, in the node name.
[..] > + > + dsi_phy: dsi-phy0@ae94400 {
phy@ae94400
Regards, Bjorn
| |