lkml.org 
[lkml]   [2020]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v12] x86/split_lock: Enable split lock detection by kernel
Date
>>  static void __init split_lock_setup(void)
>> {
>> - enum split_lock_detect_state sld = sld_state;
>> + enum split_lock_detect_state sld;
>
> This is bike-shedding, but initializing sld = sld_warn here would have
> been enough with no other changes to the patch I think?

Not quite. If there isn't a command line option, we get here:

if (ret < 0)
goto print;

which skips copying the local "sld" to the global "sld_state".

-Tony
\
 
 \ /
  Last update: 2020-01-23 18:16    [W:1.828 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site