Messages in this thread | | | Date | Thu, 23 Jan 2020 09:48:47 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v3] dynamic_debug: allow to work if debugfs is disabled |
| |
On Wed, Jan 22, 2020 at 01:43:46PM -0800, Randy Dunlap wrote: > Hi Greg, > > If you make any more changes: > > On 1/22/20 11:31 AM, Greg Kroah-Hartman wrote: > > diff --git a/Documentation/admin-guide/dynamic-debug-howto.rst b/Documentation/admin-guide/dynamic-debug-howto.rst > > index 252e5ef324e5..41f43a373a6a 100644 > > --- a/Documentation/admin-guide/dynamic-debug-howto.rst > > +++ b/Documentation/admin-guide/dynamic-debug-howto.rst > > @@ -54,6 +54,9 @@ If you make a mistake with the syntax, the write will fail thus:: > > <debugfs>/dynamic_debug/control > > -bash: echo: write error: Invalid argument > > > > +Note, for systems without 'debugfs' enabled, the control file can be > > +also found in ``/proc/dynamic_debug/control``. > > Mostly drop the "also". How about: > > > +Note, for systems without 'debugfs' enabled, the control file is located > > +in ``/proc/dynamic_debug/control``.
Much nicer, I'll respin it with this change, thanks for the review!
greg k-h
| |