lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 154/222] net: dsa: sja1105: Dont error out on disabled ports with no phy-mode
    Date
    From: Vladimir Oltean <vladimir.oltean@nxp.com>

    [ Upstream commit 27afe0d34e9121a3d61cc0af9b17c2542dadde24 ]

    The sja1105_parse_ports_node function was tested only on device trees
    where all ports were enabled. Fix this check so that the driver
    continues to probe only with the ports where status is not "disabled",
    as expected.

    Fixes: 8aa9ebccae87 ("net: dsa: Introduce driver for NXP SJA1105 5-port L2 switch")
    Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/dsa/sja1105/sja1105_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/dsa/sja1105/sja1105_main.c
    +++ b/drivers/net/dsa/sja1105/sja1105_main.c
    @@ -619,7 +619,7 @@ static int sja1105_parse_ports_node(stru
    struct device *dev = &priv->spidev->dev;
    struct device_node *child;

    - for_each_child_of_node(ports_node, child) {
    + for_each_available_child_of_node(ports_node, child) {
    struct device_node *phy_node;
    int phy_mode;
    u32 index;

    \
     
     \ /
      Last update: 2020-01-22 14:27    [W:4.015 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site