lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 058/222] mtd: rawnand: gpmi: Fix suspend/resume problem
    Date
    From: Esben Haabendal <esben@geanix.com>

    commit 5bc6bb603b4d0c8802af75e4932232683ab2d761 upstream.

    On system resume, the gpmi clock must be enabled before accessing gpmi
    block. Without this, resume causes something like

    [ 661.348790] gpmi_reset_block(5cbb0f7e): module reset timeout
    [ 661.348889] gpmi-nand 1806000.gpmi-nand: Error setting GPMI : -110
    [ 661.348928] PM: dpm_run_callback(): platform_pm_resume+0x0/0x44 returns -110
    [ 661.348961] PM: Device 1806000.gpmi-nand failed to resume: error -110

    Fixes: ef347c0cfd61 ("mtd: rawnand: gpmi: Implement exec_op")
    Cc: stable@vger.kernel.org
    Signed-off-by: Esben Haabendal <esben@geanix.com>
    Acked-by: Han Xu <han.xu@nxp.com>
    Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
    +++ b/drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c
    @@ -148,6 +148,10 @@ static int gpmi_init(struct gpmi_nand_da
    struct resources *r = &this->resources;
    int ret;

    + ret = pm_runtime_get_sync(this->dev);
    + if (ret < 0)
    + return ret;
    +
    ret = gpmi_reset_block(r->gpmi_regs, false);
    if (ret)
    goto err_out;
    @@ -179,8 +183,9 @@ static int gpmi_init(struct gpmi_nand_da
    */
    writel(BM_GPMI_CTRL1_DECOUPLE_CS, r->gpmi_regs + HW_GPMI_CTRL1_SET);

    - return 0;
    err_out:
    + pm_runtime_mark_last_busy(this->dev);
    + pm_runtime_put_autosuspend(this->dev);
    return ret;
    }


    \
     
     \ /
      Last update: 2020-01-22 14:20    [W:4.929 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site