lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: x86/cleanups] x86/tsc: Remove redundant assignment
The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID: 4144fddbd3932b59370e6e279002991c3e2b2fc6
Gitweb: https://git.kernel.org/tip/4144fddbd3932b59370e6e279002991c3e2b2fc6
Author: Mateusz Nosek <mateusznosek0@gmail.com>
AuthorDate: Sat, 18 Jan 2020 18:11:43 +01:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Wed, 22 Jan 2020 13:52:42 +01:00

x86/tsc: Remove redundant assignment

Previously, the assignment to the local variable 'now' took place
before the for loop. The loop is unconditional so it will be entered
at least once. The variable 'now' is reassigned in the loop and is not
used before reassigning. Therefore, the assignment before the loop is
unnecessary and can be removed.

No code changed:

# arch/x86/kernel/tsc_sync.o:

text data bss dec hex filename
3569 198 44 3811 ee3 tsc_sync.o.before
3569 198 44 3811 ee3 tsc_sync.o.after

md5:
36216de29b208edbcd34fed9fe7f7b69 tsc_sync.o.before.asm
36216de29b208edbcd34fed9fe7f7b69 tsc_sync.o.after.asm

[ bp: Massage commit message. ]

Signed-off-by: Mateusz Nosek <mateusznosek0@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200118171143.25178-1-mateusznosek0@gmail.com
---
arch/x86/kernel/tsc_sync.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/tsc_sync.c b/arch/x86/kernel/tsc_sync.c
index b8acf63..32a8187 100644
--- a/arch/x86/kernel/tsc_sync.c
+++ b/arch/x86/kernel/tsc_sync.c
@@ -233,7 +233,6 @@ static cycles_t check_tsc_warp(unsigned int timeout)
* The measurement runs for 'timeout' msecs:
*/
end = start + (cycles_t) tsc_khz * timeout;
- now = start;

for (i = 0; ; i++) {
/*
\
 
 \ /
  Last update: 2020-01-22 14:03    [W:0.035 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site