lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 36/76] rtc: msm6242: Fix reading of 10-hour digit
    Date
    From: Kars de Jong <jongk@linux-m68k.org>

    commit e34494c8df0cd96fc432efae121db3212c46ae48 upstream.

    The driver was reading the wrong register as the 10-hour digit due to
    a misplaced ')'. It was in fact reading the 1-second digit register due
    to this bug.

    Also remove the use of a magic number for the hour mask and use the define
    for it which was already present.

    Fixes: 4f9b9bba1dd1 ("rtc: Add an RTC driver for the Oki MSM6242")
    Tested-by: Kars de Jong <jongk@linux-m68k.org>
    Signed-off-by: Kars de Jong <jongk@linux-m68k.org>
    Link: https://lore.kernel.org/r/20191116110548.8562-1-jongk@linux-m68k.org
    Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/rtc/rtc-msm6242.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/drivers/rtc/rtc-msm6242.c
    +++ b/drivers/rtc/rtc-msm6242.c
    @@ -132,7 +132,8 @@ static int msm6242_read_time(struct devi
    msm6242_read(priv, MSM6242_SECOND1);
    tm->tm_min = msm6242_read(priv, MSM6242_MINUTE10) * 10 +
    msm6242_read(priv, MSM6242_MINUTE1);
    - tm->tm_hour = (msm6242_read(priv, MSM6242_HOUR10 & 3)) * 10 +
    + tm->tm_hour = (msm6242_read(priv, MSM6242_HOUR10) &
    + MSM6242_HOUR10_HR_MASK) * 10 +
    msm6242_read(priv, MSM6242_HOUR1);
    tm->tm_mday = msm6242_read(priv, MSM6242_DAY10) * 10 +
    msm6242_read(priv, MSM6242_DAY1);

    \
     
     \ /
      Last update: 2020-01-22 10:33    [W:2.088 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site