lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: amd: Fix for Subsequent Playback issue.
From
Date


On 22/01/20 5:44 AM, Kuninori Morimoto wrote:
>
> Hi Ravulapati
>
>> If we play audio back to back, which kills one playback
>> and immediately start another, we can hear clicks.
>> This patch fixes the issue.
>>
>> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
>> ---
> (snip)
>> + kfree(rtd);
>
> Please double check soc_new_pcm_runtime() and
> soc_free_pcm_runtime() at soc-core.c.
> Because rtd is created via devm_kzalloc(),
> and has many related resources which need to be cared when rtd was freed.
> Just kfree() is not good/enough, I think.
>
> I think you want to use is snd_soc_remove_pcm_runtime()
> instead of kfree()
>
> Thank you for your help !!
> Best regards
> ---
> Kuninori Morimoto
>
I will create a separate patch for kfree and separate one for subsequent
play back issue.

\
 
 \ /
  Last update: 2020-01-22 09:51    [W:0.048 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site