Messages in this thread | | | Subject | Re: [PATCH] ASoC: amd: Fix for Subsequent Playback issue. | From | vishnu <> | Date | Wed, 22 Jan 2020 14:18:40 +0530 |
| |
On 22/01/20 5:44 AM, Kuninori Morimoto wrote: > > Hi Ravulapati > >> If we play audio back to back, which kills one playback >> and immediately start another, we can hear clicks. >> This patch fixes the issue. >> >> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com> >> --- > (snip) >> + kfree(rtd); > > Please double check soc_new_pcm_runtime() and > soc_free_pcm_runtime() at soc-core.c. > Because rtd is created via devm_kzalloc(), > and has many related resources which need to be cared when rtd was freed. > Just kfree() is not good/enough, I think. > > I think you want to use is snd_soc_remove_pcm_runtime() > instead of kfree() > > Thank you for your help !! > Best regards > --- > Kuninori Morimoto > I will create a separate patch for kfree and separate one for subsequent play back issue.
| |