Messages in this thread Patch in this message | | | Subject | Re: [PATCH v5 18/18] svm: Allow AVIC with in-kernel irqchip mode | From | Paolo Bonzini <> | Date | Wed, 22 Jan 2020 17:06:26 +0100 |
| |
On 14/11/19 21:15, Suravee Suthikulpanit wrote: > Once run-time AVIC activate/deactivate is supported, and EOI workaround > for AVIC is implemented, we can remove the kernel irqchip split mode > requirement for AVIC. > > Hence, remove the check for irqchip split mode when enabling AVIC. > > Cc: Radim Krčmář <rkrcmar@redhat.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > --- > arch/x86/kvm/svm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 2dfdd7c..2cba5be 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -5149,7 +5149,7 @@ static void svm_set_virtual_apic_mode(struct kvm_vcpu *vcpu) > > static bool svm_get_enable_apicv(struct kvm *kvm) > { > - return avic && irqchip_split(kvm); > + return avic; > } > > static void svm_hwapic_irr_update(struct kvm_vcpu *vcpu, int max_irr) >
Since I'm going to remove get_enable_apicv, this patch will look like this instead:
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index ceead401a696..1c4a26d34913 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -2074,7 +2074,7 @@ static int svm_vm_init(struct kvm *kvm) return ret; }
- kvm_apicv_init(kvm, avic && irqchip_split(kvm)); + kvm_apicv_init(kvm, avic); return 0; }
Paolo
| |