lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 27/38] mfd: intel_soc_pmic_bxtwc: Convert to use new SCU IPC API
On Wed, Jan 22, 2020 at 02:46:21PM +0100, Greg Kroah-Hartman wrote:
> > if (ret) {
> > dev_err(pmic->dev, "Failed to read from PMIC\n");
>
> Meta-comment, the call should be the thing making that error message,
> do not force all callers to log it again, or in some other way. That
> just makes for a larger mess.

OK, I'll do that.

\
 
 \ /
  Last update: 2020-01-22 15:42    [W:0.073 / U:23.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site