lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] Crypto-engine support for parallel requests
On Wed, Jan 22, 2020 at 12:29:22PM +0000, Iuliana Prodan wrote:
>
> > do_one_request is a blocking operation on amlogic/sun8i-ce/sun8i-ss and the "documentation" is clear "@do_one_request: do encryption for current request".
> > But I agree that is a bit small for a documentation.
> >
>
> Herbert, Baolin,
>
> What do you think about do_one_requet operation: is blocking or not?
>
> There are several drivers (stm32, omap, virtio, caam) that include
> crypto-engine, and uses do_one_request as non-blocking, only the ones
> mentioned and implemented by Corentin use do_one_request as blocking.

It certainly shouldn't be blocking in the general case. The only
time when it might make sense to block is if the hardware is
incapable of using IRQs to signal completion.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2020-01-22 15:42    [W:0.063 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site