lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lib/rbtree: avoid pointless rb_node alignment
On Mon, 20 Jan 2020 09:51:44 -0800 Davidlohr Bueso <dave@stgolabs.net> wrote:

> On Mon, 20 Jan 2020, Geert Uytterhoeven wrote:
>
> >timerqueue_del() uses rbtree, and
> >
> > #define rb_parent(r) ((struct rb_node *)((r)->__rb_parent_color & ~3))
> >
> >relies on all objects being 4-byte aligned. But your patch broke that
> >assumption on m68k, where the default alignment is 2-byte.
> >
> >Andrew: please drop this patch.
>
> Yeah that's too bad. I'll send a patch improving the comment around the alignment
> once the patch is dropped.

Thanks, I'll drop this patch.

\
 
 \ /
  Last update: 2020-01-21 22:05    [W:0.073 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site