lkml.org 
[lkml]   [2020]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 34/38] platform/x86: intel_pmc_ipc: Propagate error from kstrtoul()
    Date
    kstrtoul() already returns negative error if the input was not valid so
    return it directly.

    Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
    ---
    drivers/platform/x86/intel_pmc_ipc.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c
    index f912f2a40512..eb4d65768531 100644
    --- a/drivers/platform/x86/intel_pmc_ipc.c
    +++ b/drivers/platform/x86/intel_pmc_ipc.c
    @@ -226,8 +226,9 @@ static ssize_t intel_pmc_ipc_northpeak_store(struct device *dev,
    int subcmd;
    int ret;

    - if (kstrtoul(buf, 0, &val))
    - return -EINVAL;
    + ret = kstrtoul(buf, 0, &val);
    + if (ret)
    + return ret;

    if (val)
    subcmd = 1;
    --
    2.24.1
    \
     
     \ /
      Last update: 2020-01-21 17:03    [W:3.193 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site