lkml.org 
[lkml]   [2020]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/4] drm/i915/display: conversion to new logging macros.


On Fri, 17 Jan 2020, Jani Nikula wrote:

> On Thu, 16 Jan 2020, Wambui Karuga <wambui.karugax@gmail.com> wrote:
>> This series converts the printk based logging macros in
>> drm/i915/display/intel_display.c to the new struct drm_device based
>> logging macros. This change was split into four for manageability and
>> due to the size of drm/i915/display/intel_display.c.
>
> Please still write more descriptive commit messages than "part N".
>
What would be a more descriptive subject line? I wasn't really sure about
the subject line since the series is for the same file - which is why I
went with "part N".

> What are your basing your patches on? Our CI uses
drm-tip, and it's > failing to apply the patches.
>
I'm using drm-tip, but I can rebase and try again.

Thanks.
wambui.
> BR,
> Jani.
>
>
>
>>
>> Wambui Karuga (4):
>> drm/i915/display: conversion to new logging macros part 1
>> drm/i915/display: conversion to new logging macros part 2
>> drm/i915/display: conversion to new logging macros part 3
>> drm/i915/display: convert to new logging macros part 4.
>>
>> drivers/gpu/drm/i915/display/intel_display.c | 1021 ++++++++++--------
>> 1 file changed, 596 insertions(+), 425 deletions(-)
>
> --
> Jani Nikula, Intel Open Source Graphics Center
>

\
 
 \ /
  Last update: 2020-01-17 20:26    [W:0.056 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site