lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 202/203] hexagon: work around compiler crash
    Date
    From: Nick Desaulniers <ndesaulniers@google.com>

    [ Upstream commit 63e80314ab7cf4783526d2e44ee57a90514911c9 ]

    Clang cannot translate the string "r30" into a valid register yet.

    Link: https://github.com/ClangBuiltLinux/linux/issues/755
    Link: http://lkml.kernel.org/r/20191028155722.23419-1-ndesaulniers@google.com
    Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
    Suggested-by: Sid Manning <sidneym@quicinc.com>
    Reviewed-by: Brian Cain <bcain@codeaurora.org>
    Cc: Allison Randal <allison@lohutok.net>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Richard Fontana <rfontana@redhat.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/hexagon/kernel/stacktrace.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/arch/hexagon/kernel/stacktrace.c b/arch/hexagon/kernel/stacktrace.c
    index 35f29423fda8..5ed02f699479 100644
    --- a/arch/hexagon/kernel/stacktrace.c
    +++ b/arch/hexagon/kernel/stacktrace.c
    @@ -11,8 +11,6 @@
    #include <linux/thread_info.h>
    #include <linux/module.h>

    -register unsigned long current_frame_pointer asm("r30");
    -
    struct stackframe {
    unsigned long fp;
    unsigned long rets;
    @@ -30,7 +28,7 @@ void save_stack_trace(struct stack_trace *trace)

    low = (unsigned long)task_stack_page(current);
    high = low + THREAD_SIZE;
    - fp = current_frame_pointer;
    + fp = (unsigned long)__builtin_frame_address(0);

    while (fp >= low && fp <= (high - sizeof(*frame))) {
    frame = (struct stackframe *)fp;
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-17 00:27    [W:4.578 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site