Messages in this thread | | | Date | Thu, 16 Jan 2020 12:30:02 -0500 | From | Johannes Weiner <> | Subject | Re: [PATCH v2 6/6] mm: kmem: rename (__)memcg_kmem_(un)charge_memcg() to __memcg_kmem_(un)charge() |
| |
On Thu, Jan 09, 2020 at 12:26:59PM -0800, Roman Gushchin wrote: > Drop the _memcg suffix from (__)memcg_kmem_(un)charge functions. > It's shorter and more obvious. > > These are the most basic functions which are just (un)charging the > given cgroup with the given amount of pages. > > Also fix up the corresponding comments. > > Signed-off-by: Roman Gushchin <guro@fb.com>
This looks good to me. I also appreciate the grouping of the functions by layer (first charge/uncharge, then charge_page/uncharge_page).
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
| |