| Date | Thu, 16 Jan 2020 03:38:21 -0500 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH v3 12/21] KVM: X86: Implement ring-based dirty memory tracking |
| |
On Thu, Jan 09, 2020 at 09:57:20AM -0500, Peter Xu wrote: > + /* If to map any writable page within dirty ring, fail it */ > + if ((kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff) || > + kvm_page_in_dirty_ring(vcpu->kvm, vma->vm_pgoff + pages - 1)) && > + vma->vm_flags & VM_WRITE) > + return -EINVAL;
Worth thinking about other flags. Do we want to force VM_SHARED? Disable VM_EXEC?
|