lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 569/671] of: mdio: Fix a signedness bug in of_phy_get_and_connect()
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit d7eb651212fdbafa82d485d8e76095ac3b14c193 ]

    The "iface" variable is an enum and in this context GCC treats it as
    an unsigned int so the error handling is never triggered.

    Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/of/of_mdio.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
    index 5ad1342f5682..7d2bc22680d9 100644
    --- a/drivers/of/of_mdio.c
    +++ b/drivers/of/of_mdio.c
    @@ -370,7 +370,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev,
    int ret;

    iface = of_get_phy_mode(np);
    - if (iface < 0)
    + if ((int)iface < 0)
    return NULL;
    if (of_phy_is_fixed_link(np)) {
    ret = of_phy_register_fixed_link(np);
    --
    2.20.1
    \
     
     \ /
      Last update: 2020-01-16 18:12    [W:4.054 / U:0.340 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site