Messages in this thread | | | From | Alexander Potapenko <> | Date | Tue, 14 Jan 2020 18:24:17 +0100 | Subject | Re: [PATCH -rcu] kcsan: Make KCSAN compatible with lockdep |
| |
> --- a/kernel/kcsan/core.c > +++ b/kernel/kcsan/core.c > @@ -337,7 +337,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type) > * detection point of view) to simply disable preemptions to ensure > * as many tasks as possible run on other CPUs. > */ > - local_irq_save(irq_flags); > + raw_local_irq_save(irq_flags);
Please reflect the need to use raw_local_irq_save() in the comment.
> > watchpoint = insert_watchpoint((unsigned long)ptr, size, is_write); > if (watchpoint == NULL) { > @@ -429,7 +429,7 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type) > > kcsan_counter_dec(KCSAN_COUNTER_USED_WATCHPOINTS); > out_unlock: > - local_irq_restore(irq_flags); > + raw_local_irq_restore(irq_flags);
Ditto
| |